Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark FacileData::as.<BiocBox> functions as .Defunct() #27

Open
tomsing1 opened this issue Sep 6, 2023 · 2 comments
Open

Mark FacileData::as.<BiocBox> functions as .Defunct() #27

tomsing1 opened this issue Sep 6, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@tomsing1
Copy link
Contributor

tomsing1 commented Sep 6, 2023

Reproducible example:

library(FacileData)
fds <- exampleFacileDataSet()
as.DGEList(fds)  # works
as.SummarizedExperiment(fds)   # error:

Error in as.SummarizedExperiment.data.frame(x, covariates, feature_ids,  : 
  is.FacileDataSet(.fds) is not TRUE
@lianos
Copy link
Member

lianos commented Sep 6, 2023

Thanks for the report!

I'm not quite sure what's going south there, but these as.<sometihng> functions should be (will be) nuked and are currently replaced with biocbox(fds, "<something>")

So, you can do:

y <- biocbox(fds, "DGEList")
se <- biocbox(fds, "SummarizedExperiment")

... using the latest version from @main, of course :-)

Let me know if that works for you, and we can convert this issue to one that makes sure we .Defunct() all these as.<BiocBox> functions.

@tomsing1
Copy link
Contributor Author

tomsing1 commented Sep 6, 2023

Yup biocbox works for this. Thank you for pointing it out!

@lianos lianos changed the title FacileData::as.SummarizedExperiment appears to be broken Mark FacileData::as.<BiocBox> functions as .Defunct() Sep 6, 2023
@lianos lianos self-assigned this Sep 6, 2023
@lianos lianos added the enhancement New feature or request label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants