Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming. #40

Open
1 of 2 tasks
FarahZaqout opened this issue Sep 3, 2019 · 1 comment
Open
1 of 2 tasks

Consistent naming. #40

FarahZaqout opened this issue Sep 3, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request Priority-2

Comments

@FarahZaqout
Copy link
Contributor

FarahZaqout commented Sep 3, 2019

Hey team, good work so far. I have some feedback about the way we name our files and branches inconsistently.

  • For our files, we should use one single style and stick to it. We are mixing camelCase and PascalCase in the server files (controllers).

    • Our controllers should be inline with the rest of the server files.
  • An exception in react, is that we use PascalCase to name component, because it is expected that they export a class. For client files that do not export react components, we should use camelCase as well.

  • Branch names should also follow one style. (Saja's PR was named fileStructure, while Rand and Nadeen's were named react-router-setup and database).

    • We should agree on one naming style for the branches and stick to it.

We should document what we agree on here in this issue as well.

@FarahZaqout
Copy link
Contributor Author

@RandInaim @SajaLahaleeh @saharAdem @nadeen123 Did u girls see this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority-2
Projects
None yet
Development

No branches or pull requests

5 participants