You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey team, good work so far. I have some feedback about the way we name our files and branches inconsistently.
For our files, we should use one single style and stick to it. We are mixing camelCase and PascalCase in the server files (controllers).
Our controllers should be inline with the rest of the server files.
An exception in react, is that we use PascalCase to name component, because it is expected that they export a class. For client files that do not export react components, we should use camelCase as well.
Branch names should also follow one style. (Saja's PR was named fileStructure, while Rand and Nadeen's were named react-router-setup and database).
We should agree on one naming style for the branches and stick to it.
We should document what we agree on here in this issue as well.
The text was updated successfully, but these errors were encountered:
Hey team, good work so far. I have some feedback about the way we name our files and branches inconsistently.
For our files, we should use one single style and stick to it. We are mixing
camelCase
andPascalCase
in the server files (controllers).An exception in react, is that we use
PascalCase
to name component, because it is expected that they export a class. For client files that do not export react components, we should usecamelCase
as well.Branch names should also follow one style. (Saja's PR was named
fileStructure
, while Rand and Nadeen's were namedreact-router-setup
anddatabase
).We should document what we agree on here in this issue as well.
The text was updated successfully, but these errors were encountered: