Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we use *.page files to get keys? #28

Open
dneise opened this issue Oct 18, 2017 · 1 comment
Open

should we use *.page files to get keys? #28

dneise opened this issue Oct 18, 2017 · 1 comment

Comments

@dneise
Copy link
Member

dneise commented Oct 18, 2017

At the moment the keys we use are hardcoded, e.g. here:
https://github.com/fact-project/smart_fact_crawler/blob/master/smart_fact_crawler/__init__.py#L68

But we could use the *.page files to get the keys e.g. this one:
http://fact-project.org/smartfact/struct/tracking.page

However the keys are not valid variable names. And in case there are multiple values in one line, as e.g. in
http://fact-project.org/smartfact/struct/fact.page
there is no valid variable name.

@maxnoe
Copy link
Member

maxnoe commented Oct 19, 2017

Maybe a better plan is not to use them as keys but to store the ones which were used to implement the current version and compare them to the ones on the server. Raising at least a warning if they do not match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants