fix: improve fetch_for_repository performance by preventing reposit…

…ory classes constantizing
factorialco · Dec 5, 2024 · 5ec9070 · 5ec9070
1 parent 17696f5
commit 5ec9070
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/lib/resource_registry/registry.rb b/lib/resource_registry/registry.rb
@@ -1,5 +1,5 @@
+# typed: strict
 # frozen_string_literal: true
-# typed: false
 
 require_relative "resource"
 require_relative "capabilities/capability_config"
@@ -49,9 +49,11 @@ def fetch!(identifier)
       ).returns(T.nilable(Resource))
     end
     def fetch_for_repository(repository_class)
-      fetch_all.values.find { |r| r.repository == repository_class }
+      fetch_all.values.find { |r| r.repository_raw == repository_class.to_s }
     end
 
+    alias find_for_repository fetch_for_repository
+
     sig { returns(T::Hash[String, Resource]) }
     def fetch_all
       resources
@@ -71,15 +73,6 @@ def fetch_with_capabilities(*capabilities)
       end
     end
 
-    sig do
-      params(
-        repository: T::Class[ResourceRegistry::Repositories::Base[T.untyped]]
-      ).returns(T.nilable(Resource))
-    end
-    def find_by_repository(repository)
-      fetch_all.values.find { |resource| resource.repository == repository }
-    end
-
     private
 
     sig { returns(T::Hash[String, Resource]) }

diff --git a/lib/resource_registry/resource.rb b/lib/resource_registry/resource.rb
@@ -210,7 +210,7 @@ def verbs_except(except)
     def dump
       {
         "identifier" => identifier,
-        "repository" => repository.to_s,
+        "repository" => repository_raw,
         "description" => description,
         "relationships" => relationships.values.map(&:dump),
         "capabilities" =>