Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the gitlab hooks via API #10

Open
ant31 opened this issue Jun 28, 2017 · 5 comments
Open

Create the gitlab hooks via API #10

ant31 opened this issue Jun 28, 2017 · 5 comments
Assignees

Comments

@ant31
Copy link
Contributor

ant31 commented Jun 28, 2017

https://docs.gitlab.com/ce/api/projects.html#add-project-hook

@samba samba self-assigned this Dec 8, 2017
@samba
Copy link
Contributor

samba commented Dec 8, 2017

I have started work on this issue.

Currently make test (etc) show that we have 0% coverage for pipeline.py, which will have important changes in this work. I don't see any tests in the codebase that try to integrate the flow {github event => trigger gitlab pipeline}, across this entire path.

@ant31 do you have any suggestions on a low-impact way to test changes in this workflow? Or should creating those tests be seen as a prerequisite?

/cc @joejulian

@ant31
Copy link
Contributor Author

ant31 commented Dec 9, 2017

project doesnt have e2e nor unit tests.
As it s growing we need to add them for sure but maybe not all at once.

Unless you have strong opinion about it, I am good with manual QA

@joejulian
Copy link
Member

IMHO

I would love to see tests. Any tests even if they're only a small fraction of what should be tested. If you're willing to add tests for your new code, please do. If there are things you cannot test, skip that thing and create an issue. Don't make writing tests a burden.

@ant31
Copy link
Contributor Author

ant31 commented Mar 5, 2018

@samba do you have a WIP for this issue ?

@samba
Copy link
Contributor

samba commented Mar 5, 2018

@ant31 Nothing yet material, mostly exploratory, identifying which methods were no longer relevant if the curl callback was removed. (I actually paused work on it some time ago.)

If this is useful, I can share, however I believe your familiarity with the codebase will make you more effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants