Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed topic is not calculated by design #204

Open
nugaon opened this issue Dec 20, 2022 · 0 comments · May be fixed by #223
Open

Feed topic is not calculated by design #204

nugaon opened this issue Dec 20, 2022 · 0 comments · May be fixed by #223
Assignees

Comments

@nugaon
Copy link
Collaborator

nugaon commented Dec 20, 2022

The feed topic construction for arbitrary strings according to the documentation only using keccak256 hashing function such as
https://github.com/fairDataSociety/FIPs/blob/master/text/0061-personal-storage.md?plain=1#L170

In FDP Storage (and thereby in FairOS), the topic is calculated every time as
https://github.com/fairDataSociety/fdp-storage/blob/master/src/feed/api.ts#L26

which takes the BMT Hash of the arbitrary string for every topic.
The BMT hashing algorithm is a more heavier task without any yield, but with additional complexity.

Additionally, POD_TOPIC constant has value Pods in the library which is also not identical with the FIP version PODs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants