Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that downloaded data is correct #211

Open
IgorShadurin opened this issue Jan 20, 2023 · 2 comments
Open

Validate that downloaded data is correct #211

IgorShadurin opened this issue Jan 20, 2023 · 2 comments

Comments

@IgorShadurin
Copy link
Collaborator

IgorShadurin commented Jan 20, 2023

It would be nice to check the downloaded data due to an issue in Bee ethersphere/bee#3714.

@nugaon
Copy link
Collaborator

nugaon commented Jan 20, 2023

how do you want to check that? building up bmt for all downloaded data on client side is quite heavy.
IMO the Bee client should handle this on request (that it does maybe, just the http error code handling on streaming is wrong)

@IgorShadurin
Copy link
Collaborator Author

how do you want to check that? building up bmt for all downloaded data on client side is quite heavy. IMO the Bee client should handle this on request (that it does maybe, just the http error code handling on streaming is wrong)

If the bmt validation is slow, then a new field in the metadata can be added with a hash of some browser-friendly algorithm to check the integrity of the file.

Even something like md5 can be used, since the hash is stored encrypted in the metadata and cannot be used by a malicious gateway to generate a collision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants