Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EpochID calculation #217

Open
nugaon opened this issue Feb 15, 2023 · 0 comments · May be fixed by #223
Open

EpochID calculation #217

nugaon opened this issue Feb 15, 2023 · 0 comments · May be fixed by #223
Assignees
@IgorShadurin
Labels
enhancement New feature or request

Comments

@nugaon
Copy link
Collaborator

nugaon commented Feb 15, 2023

getId function in feed/handler.ts seems overcomplicated, you do not need to calculate binary merkle tree to get 32 bytes of topic. you should just hash the topic and the uint64 bytes of epoch ID together. it is slower currently than what has just been mentioned before and also more expensive to elaborate any feed-signature related logic in smart contract later.
@nugaon nugaon added the enhancement New feature or request label Feb 15, 2023
@IgorShadurin IgorShadurin linked a pull request Mar 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgorShadurin IgorShadurin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: bmtHashString replaced with keccak256Hash fairDataSociety/fdp-storage
2 participants
@IgorShadurin @nugaon