-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Musketeer variant #762
base: master
Are you sure you want to change the base?
Musketeer variant #762
Conversation
Thank you. Since there already are several other open PRs review will likely take some time. Could you please in the meantime try to fix the errors/warnings reported by CI? |
@alperatalayn @cross-of-north @sayantandey @chris-heldeis Thanks for your PRs. May I ask you to align on your PRs and come up with a single PR? I have fairly limited time for reviews, so reviewing 4 versions of the same PR is not really practicable for me. Would be very nice if you get to a consensus on which is the most refined version that should be reviewed. |
I consider my version to be the most refined.
|
My PR (as I mentioned in the name 'Fixes For#762 Pipeline fails') was to fix the build issues in the PR pipelnie from @alperatalayn version and make sure the windows distributables are successfully built and being able to run, I created the build to check the tests in PR pipeline (the make builds are already tested in my local) after fixing those issue. So, yes you can ignore my PR considering this. |
No description provided.