-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numeric currency code by ISO 4217 standard #2289
Comments
Thank you for your feature proposal. We marked it as "waiting for user interest" for now to gather some feedback from our community:
We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements. We will start the implementation based on:
We do this because:
|
Team decision This feature request seems reasonable. Due to the ISO standardization we accept it even tho the upvote number is comparativly low. @letehaha Are you interested in implementing this? |
Thanks @xDivisionByZerox, I'll check this weekend what it requires and if I'll have time for it. Will keep you posted |
Hey @xDivisionByZerox, sorry but right now I have no capacity. I'll keep this in mind for the time I'm free, but no promises :) |
@letehaha all good. I'll go ahead and open this issue for potential external contributions. Since the feature would follow an ISO standard, I even think this would be great for first-time contributors. |
@xDivisionByZerox I have some time and I really like what you guys are working on. I'll look into this feature! |
Clear and concise description of the problem
Right now
finance.currency
has a structure of{ code: 'USD', name: 'US Dollar', symbol: '$' }
, but in many financial application I usually see numeric currency code usage, instead of string (so840
instead ofUSD
).Suggested solution
The suggestion is to add
numericCode
(probably needs a better name) to the currency object insidefaker.finance
.I can try to implement that by myself
Alternative
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: