Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Commit

Permalink
chore: remove deprecation warning (#733)
Browse files Browse the repository at this point in the history
  • Loading branch information
drochetti authored Jan 30, 2023
1 parent 94bf63c commit 99521ad
Showing 1 changed file with 0 additions and 31 deletions.
31 changes: 0 additions & 31 deletions src/fal/cli/cli.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import argparse
from typing import List
import sys

Expand All @@ -9,8 +8,6 @@
from .fal_runner import fal_run
from fal.telemetry import telemetry

import dbt.exceptions
import dbt.ui
from faldbt.logger import log_manager


Expand All @@ -33,8 +30,6 @@ def _cli(argv: List[str]):

if parsed.command == "flow":
if parsed.flow_command == "run":
_warn_deprecated_flags(parsed)

exit_code = fal_flow_run(parsed)
if exit_code:
raise SystemExit(exit_code)
Expand Down Expand Up @@ -66,29 +61,3 @@ def _cli(argv: List[str]):
if e.message == "Use `isolate-cloud login` flow":
raise RuntimeError("Login by running `fal cloud login`.")
raise e


# TODO: remove in fal 0.6.0
def _warn_deprecated_flags(parsed: argparse.Namespace):
if parsed.experimental_flow:
dbt.exceptions.warn(
"Flag `--experimental-flow` is DEPRECATED and is treated as a no-op.\n"
"This flag will make fal error in 0.6"
)
if parsed.experimental_python_models:
dbt.exceptions.warn(
"Flag `--experimental-models` is DEPRECATED and is treated as a no-op.\n"
"This flag will make fal error in 0.6"
)
if parsed.experimental_threads:
dbt.exceptions.warn(
"Flag `--experimental-threads` is DEPRECATED and is treated as a no-op.\n"
"Using valued passed for `--threads` instead.\n"
"This flag will make fal error in 0.6"
)
# NOTE: take the number of threads to use from the experimental_threads
if parsed.threads:
dbt.exceptions.warn(
f"WARNING: Overwriting `--threads` value with `--experimental-threads` value"
)
parsed.threads = parsed.experimental_threads

0 comments on commit 99521ad

Please sign in to comment.