From 2c87dec99bc02279789c0876b55cfdb74ac3abe9 Mon Sep 17 00:00:00 2001
From: Batuhan Taskaya <batuhan@python.org>
Date: Mon, 28 Aug 2023 17:21:08 +0300
Subject: [PATCH 1/2] feat: strict cache when external verification isn't
 possible

---
 src/isolate/backends/settings.py   |  6 ++++++
 src/isolate/backends/virtualenv.py | 11 +++++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/src/isolate/backends/settings.py b/src/isolate/backends/settings.py
index 85e128c..3ec1132 100644
--- a/src/isolate/backends/settings.py
+++ b/src/isolate/backends/settings.py
@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import os
 import shutil
 import tempfile
 from contextlib import contextmanager
@@ -16,6 +17,7 @@
     from isolate.backends import BaseEnvironment
 
 _SYSTEM_TEMP_DIR = Path(tempfile.gettempdir())
+_STRICT_CACHE = os.getenv("ISOLATE_STRICT_CACHE", "0") == "1"
 
 
 @dataclass(frozen=True)
@@ -23,6 +25,7 @@ class IsolateSettings:
     cache_dir: Path = Path(user_cache_dir("isolate", "isolate"))
     serialization_method: str = "pickle"
     log_hook: Callable[[Log], None] = print
+    strict_cache: bool = _STRICT_CACHE
 
     def log(self, log: Log) -> None:
         self.log_hook(log)
@@ -82,6 +85,9 @@ def cache_dir_for(self, backend: BaseEnvironment) -> Path:
         environment_base_path.mkdir(exist_ok=True, parents=True)
         return environment_base_path / backend.key
 
+    def completion_marker_for(self, path: Path) -> Path:
+        return path / ".isolate.completed"
+
     replace = replace
 
 
diff --git a/src/isolate/backends/virtualenv.py b/src/isolate/backends/virtualenv.py
index 2b649e7..5f24527 100644
--- a/src/isolate/backends/virtualenv.py
+++ b/src/isolate/backends/virtualenv.py
@@ -127,9 +127,15 @@ def create(self, *, force: bool = False) -> Path:
         virtualenv = optional_import("virtualenv")
 
         venv_path = self.settings.cache_dir_for(self)
+        completion_marker = self.settings.completion_marker_for(venv_path)
         with self.settings.cache_lock_for(venv_path):
-            if venv_path.exists() and not force:
-                return venv_path
+            if not force:
+                is_cached = venv_path.exists()
+                if self.settings.strict_cache:
+                    is_cached &= completion_marker.exists()
+
+                if is_cached:
+                    return venv_path
 
             self.log(f"Creating the environment at '{venv_path}'")
 
@@ -145,6 +151,7 @@ def create(self, *, force: bool = False) -> Path:
                 )
 
             self.install_requirements(venv_path)
+            completion_marker.touch()
 
         self.log(f"New environment cached at '{venv_path}'")
         return venv_path

From 498cda24195e193f127a98f2e5f45608a0d1bdf8 Mon Sep 17 00:00:00 2001
From: Batuhan Taskaya <batuhan@python.org>
Date: Tue, 31 Oct 2023 00:38:27 +0300
Subject: [PATCH 2/2] Add isolate stuff

---
 src/isolate/server/server.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/isolate/server/server.py b/src/isolate/server/server.py
index 5d29f64..6f43f50 100644
--- a/src/isolate/server/server.py
+++ b/src/isolate/server/server.py
@@ -32,6 +32,8 @@
 from isolate.server.health_server import HealthServicer
 from isolate.server.interface import from_grpc, to_grpc
 
+MAX_GRPC_WAIT_TIMEOUT = float(os.getenv("ISOLATE_MAX_GRPC_WAIT_TIMEOUT", 10.0))
+
 # Whether to inherit all the packages from the current environment or not.
 INHERIT_FROM_LOCAL = os.getenv("ISOLATE_INHERIT_FROM_LOCAL") == "1"
 
@@ -132,7 +134,7 @@ def _allocate_new_agent(
                     agent.terminate()
 
         bound_context = ExitStack()
-        stub = bound_context.enter_context(connection._establish_bridge())
+        stub = bound_context.enter_context(connection._establish_bridge(max_wait_timeout=MAX_GRPC_WAIT_TIMEOUT))
         return RunnerAgent(stub, queue, bound_context)
 
     def _identify(self, connection: LocalPythonGRPC) -> Tuple[Any, ...]: