Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation for from_config() of all backends #10

Open
isidentical opened this issue Oct 7, 2022 · 0 comments
Open

Schema validation for from_config() of all backends #10

isidentical opened this issue Oct 7, 2022 · 0 comments

Comments

@isidentical
Copy link
Collaborator

from_config() should not ignore extra parameters, instead it should complain very verbosely about it.

@classmethod
def from_config(
cls,
config: Dict[str, Any],
context: ContextType = GLOBAL_CONTEXT,
) -> BaseEnvironment:
"""Create a new environment from the given configuration."""
raise NotImplementedError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant