Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(replicator): reactions and storage_allocations not backfilling #1580

Closed
vinliao opened this issue Nov 11, 2023 · 3 comments
Closed

bug(replicator): reactions and storage_allocations not backfilling #1580

vinliao opened this issue Nov 11, 2023 · 3 comments
Assignees
Labels
s-triage Needs to be reviewed, designed and prioritized

Comments

@vinliao
Copy link
Contributor

vinliao commented Nov 11, 2023

What is the bug?
Reaction table on replicator not backfilling, but it listens to new reactions. Screenshot below shows me backfilling my stuff, but reactions and storage_allocations stays zero.

image

When other tables (casts and stuff) have finished backfilling, new reactions are listened:

image

How can it be reproduced? (optional)
curl -sSL https://download.farcaster.xyz/bootstrap-replicator.sh | bash and go from scratch, have reproduced this twice.

Additional context (optional)
Edit: wondering what specific Replicator version I can install that doesn't have this problem, and how do I install it?

@github-actions github-actions bot added the s-triage Needs to be reviewed, designed and prioritized label Nov 11, 2023
@zachterrell57
Copy link
Contributor

+1

@artlu99
Copy link

artlu99 commented Nov 18, 2023

when Replicator was under examples/, the backfill looked like:

  • casts
  • reactions
  • signers
  • verifications
  • UserData

[previous code]

Now that Replicator is standalone under apps/, it appears that the reactions backfill logic (likes+recasts) got dropped, as did the UserData logic. It may be that this is handled elsewhere, but I haven't found it so far.

New logic:

  • casts
  • links
  • verifications
  • UserNameProofs
  • otherOnChainEvents

[new code]

I suspect that any new Replicator database, or any one that had downtime (e.g., to upgrade), currently has gaps in Reactions and possibly UserData

@sds sds self-assigned this Nov 28, 2023
@sds
Copy link
Member

sds commented Nov 28, 2023

Thanks for the report!

@zachterrell57 did us all a solid favor and fixed this in #1589. It has been released in version 0.2.6 of the Replicator.

@sds sds closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s-triage Needs to be reviewed, designed and prioritized
Projects
None yet
Development

No branches or pull requests

4 participants