Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev experience #46

Open
2 of 3 tasks
Eomm opened this issue Jan 11, 2023 · 17 comments
Open
2 of 3 tasks

Dev experience #46

Eomm opened this issue Jan 11, 2023 · 17 comments

Comments

@Eomm
Copy link
Member

Eomm commented Jan 11, 2023

We must work to improve the dev experience before working on this website takes days to run and build.

The issues to solve are:

  • load a subset of versions to speed up the npm start command. Note that it exists the onlyIncludeVersions for this purpose
  • generate static contents (plugins.json, benchmarks.json etc..) on the fly because the website will not start without these mandatories files
  • suggestions?
@Eomm Eomm self-assigned this Jan 11, 2023
@Eomm Eomm moved this to 🏗 In Progress in Fastify new Website Jan 11, 2023
This was referenced Jan 11, 2023
@Eomm Eomm pinned this issue Jan 15, 2023
@Eomm Eomm removed their assignment Jan 15, 2023
@Eomm Eomm moved this from 🏗 In Progress to 💡 Todo in Fastify new Website Jan 15, 2023
@jonnydgreen
Copy link

I'll load up the website locally and report back if I think of any suggestions :)

@AugustinMauroy
Copy link
Contributor

Should we use typescript (tsx)?

@AugustinMauroy
Copy link
Contributor

I can't launch the project locally. It should be enough to do an npm install then npm start.

@AugustinMauroy
Copy link
Contributor

What do you think about creating a slack channel to discuss the project?

@Eomm
Copy link
Member Author

Eomm commented Jan 25, 2023

What do you think about creating a slack channel to discuss the project?

we can create a discord one - will do later today

I can't launch the project locally

Please, read the readme and run npm run build:website too. of course, this is one of the parts we need to improve 😄

@Eomm
Copy link
Member Author

Eomm commented Jan 25, 2023

I have created the discord channel: https://discord.com/channels/725613461949906985/1067900422376935504

@AugustinMauroy
Copy link
Contributor

@Eomm
Copy link
Member Author

Eomm commented Jan 26, 2023

You can find it in the main fastify repo
https://discord.gg/fastify

@aradwann
Copy link
Contributor

aradwann commented Mar 8, 2023

  • When I opened the repo in Vscode locally, the colors changed, I think it is too vibrant for me 😅
    Screenshot from 2023-03-08 16-40-51
    is it necessary to keep the colors saved in Vscode JSON?

  • I wonder if there could another way other than installing GitHub CLI to run the website locally.

@Eomm
Copy link
Member Author

Eomm commented Mar 8, 2023

When I opened the repo in Vscode locally, the colors changed, I think it is too vibrant for me

Here my statement #60 (review)
TLDR: Yes, remove it and send a PR, but I think the suggested plugins are useful

I wonder if there could another way other than installing GitHub CLI to run the website locally.

Yes, but we need someone to replace it with bash scripting + we will need another GitHub token. the client is handy because it deals with it without annoying the dev IMHO

@metcoder95
Copy link
Member

Sadly I've never contributed to the website repo, but my take from the comments it seems that we are mostly lacking portability to be able to run the project easily in locally.

Is there anything else do you think is missed or requires re-work?

@msbn21
Copy link

msbn21 commented Aug 3, 2023

@Eomm, I am trying to launch the website locally on my machine, I am following the instructions provided in fastify/website repo to launch the website locally, however npm start command keeps complaining about missing static/generated/benchmarks.json file while running docusaurus start, can someone please help me with this ?

@Eomm
Copy link
Member Author

Eomm commented Aug 4, 2023

What is the output of npm run build:website?
What is your system?

@msbn21
Copy link

msbn21 commented Aug 4, 2023

I am using a mac, when i run npm run build:website it downloads the releases and then it throws this error
node:internal/process/promises:289
triggerUncaughtException(err, true /* fromPromise */);
^

Error: Client network socket disconnected before secure TLS connection was established
at connResetException (node:internal/errors:720:14)
at TLSSocket.onConnectEnd (node:_tls_wrap:1682:19)
at TLSSocket.emit (node:events:524:35)
at endReadableNT (node:internal/streams/readable:1378:12)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
code: 'ECONNRESET',
path: undefined,
host: 'raw.githubusercontent.com',
port: 443,
localAddress: null
}

And then it fails with error [ERROR] Error: Missing generated file: static/generated/benchmarks.json. Run the "npm run build:website" once.

@Eomm
Copy link
Member Author

Eomm commented Aug 5, 2023

It seems an error connecting to github. are you logged in with your cli?
could you add all the output? it help us to understand which step of the process blocks you

@msbn21
Copy link

msbn21 commented Aug 5, 2023

Yes, it was github connectivity indeed. I have logged in but the connection was somehow not getting established, i am able to launch the application now. Please let me know if there are any immediate tasks which i can take up and start contributing.

@Eomm
Copy link
Member Author

Eomm commented Aug 5, 2023

I would start from this one: #131

No idea here - but you can add be creative!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💡 Todo
Development

No branches or pull requests

6 participants