Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build can fail if a string matching the KV Store name appears in fastly.toml #25

Open
kpfleming opened this issue Mar 19, 2025 · 0 comments

Comments

@kpfleming
Copy link
Contributor

console.error("improperly configured entry for '${kvStoreName}' in fastly.toml");

If the fastly.toml file happens to contain the string matching the name of the configured KV Store, anywhere in the file, then this check will cause the build to fail. In my case I used the same string for the project's name as for the KV Store, so this check fails every time if the build has not previously put a list of assets into the fastly.toml file.

I suspect this check was put in place to catch situations where the user had their own configuration for the KV Store already present in fastly.toml, but the check is too 'greedy' as it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant