Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: SubtleCrypto support for RSA-PSS, ECDSA, ED25519, pkcs8 and spki #579

Closed
JakeChampion opened this issue Jul 10, 2023 · 4 comments
Closed

Feature request: SubtleCrypto support for RSA-PSS, ECDSA, ED25519, pkcs8 and spki #579

JakeChampion opened this issue Jul 10, 2023 · 4 comments

Comments

@JakeChampion
Copy link
Contributor

If I could lobby for a few more algorithms to be supported 🙏

Also pkcs8 and spki key format import/export are not to be overlooked. Developers LOOOVE to use in favour of JWKs.

I have a comprehensive test suite for different runtimes' webcrypto implementations that I could unload on js-compute-runtime eventually.

Originally posted by @panva in #440 (comment)
@jfctfl
Copy link

jfctfl commented Jul 17, 2023

Would this also include RS256? 🙂 We need RS256 to be able to verify JWTs from Fanout in a c@e js runtime - for more context: https://developer.fastly.com/learning/concepts/real-time-messaging/fanout/#validating-grip-requests

@JakeChampion
Copy link
Contributor Author

@jfctfl We support RS256, but that is not what Fanout uses, Fanout uses EC P-256, which we do not support and is already listed in this issue 👍

@jfctfl
Copy link

jfctfl commented Jul 17, 2023

I assumed it was RS256 based on this rust example. But in any case, glad to see the required algorithm listed here! 👍

jsocol added a commit to jsocol/js-compute-runtime that referenced this issue May 7, 2024
@jsocol
Add EcKeyImportParams to SubtleCrypto.importKey
9f6c27e 
In fastly#639 we added support for ECDSA keys in SubtleCrypto. This adds the
interface to the type defintions for SubtleCrypto.importKey to allow
consuming TypeScript applications to use this type of key. Partly
addresses fastly#579 and brings the library in sync with [our Fanout docs][1].

[1]: https://www.fastly.com/documentation/guides/concepts/real-time-messaging/fanout/#validating-grip-requests
@jsocol jsocol mentioned this issue May 7, 2024
Merged
@guybedford
Copy link
Member

Moved to bytecodealliance/StarlingMonkey#123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@guybedford @JakeChampion @jfctfl