You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# start the tab tab.start()
tab.Page.navigate(url="https://github.com/fate0/pychrome", _timeout=5)
# wait for loadingtab.wait(5)
# stop the tab (stop handle events and stop recv message from chrome)tab.stop()
But when I look inside the pychrome code. wait is defined like this
defwait(self, timeout=None):
ifnotself._started:
raiseRuntimeException("Tab is not running")
iftimeout:
returnself._stopped.wait(timeout)
self._recv_th.join()
self._handle_event_th.join()
returnTrue
The wait should be described as wait for thread stopped, So I think the right document should be
# start the tab tab.start()
tab.Page.navigate(url="https://github.com/fate0/pychrome", _timeout=5)
# stop the tab (stop handle events and stop recv message from chrome)tab.stop()
# wait for thread handle stoppedtab.wait(5)
The text was updated successfully, but these errors were encountered:
In the document https://fate0.github.io/pychrome/#getting-started there is sample code
But when I look inside the pychrome code.
wait
is defined like thisThe wait should be described as
wait for thread stopped
, So I think the right document should beThe text was updated successfully, but these errors were encountered: