Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sleeps From UnitTests #183

Open
MichaelWasher opened this issue Aug 13, 2019 · 2 comments
Open

Remove Sleeps From UnitTests #183

MichaelWasher opened this issue Aug 13, 2019 · 2 comments

Comments

@MichaelWasher
Copy link
Contributor

Unit tests are flakey and should not rely on sleeps to keep them in order.

Replace all sleeps with patched Mock values to trigger on expected outcome.
Add a timeout for failing tests.

https://docs.python.org/3/library/unittest.mock.html

@MichaelWasher MichaelWasher changed the title Remove Sleeps in UnitTests Remove Sleeps From UnitTests Aug 13, 2019
@MichaelWasher
Copy link
Contributor Author

Also add an option to run unit tests continuously to confirm that the flakey-ness is resolved.

@MichaelWasher
Copy link
Contributor Author

Files affected are test_chewie.py and test_chewie_mocks.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant