Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pics Failing Unsupported Types Instead of Skipping #886

Open
jhughesbiot opened this issue Jun 22, 2021 · 0 comments
Open

Pics Failing Unsupported Types Instead of Skipping #886

jhughesbiot opened this issue Jun 22, 2021 · 0 comments

Comments

@jhughesbiot
Copy link
Collaborator

If the pics file has the value false in the supported column, the pics statement is generating failure results instead of skipping. It appears there is no catch all for when a property is not supported so the default behavior is to use the false value in the testPassed variable.

This is where I believe the change needs to occur.

public void validate(String bacnetObjectType, String bacnetObjectProperty, String conformanceCode,

Likely not caught due to the faux devices pics.csv being used in testing has no objects defined as false in the support column.

https://github.com/faucetsdn/daq/blob/73d7504f7264f3b3bfafb378bdf04fe87e882781/docker/include/bacnet/bacnetFaux/src/main/resources/pics.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant