From 14864a28260fffdeb02e7d03b38e813c80a60167 Mon Sep 17 00:00:00 2001 From: Darren Cunningham Date: Fri, 8 Nov 2024 13:56:15 -0500 Subject: [PATCH] allow cursor --- client.go | 3 --- event_feed_test.go | 7 ++++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/client.go b/client.go index db8dc95..745e286 100644 --- a/client.go +++ b/client.go @@ -444,9 +444,6 @@ func (c *Client) FeedFromQuery(query *Query, opts ...FeedOptFn) (*EventFeed, err if err != nil { return nil, err } - if feedOpts.Cursor != nil { - return nil, fmt.Errorf("cannot use EventFeedCursor with FeedFromQuery") - } res, err := c.Query(query) if err != nil { diff --git a/event_feed_test.go b/event_feed_test.go index ddec9d6..30dd435 100644 --- a/event_feed_test.go +++ b/event_feed_test.go @@ -27,12 +27,13 @@ func TestEventFeed(t *testing.T) { require.ErrorContains(t, feedErr, "query should return a fauna.EventSource but got int") }) - t.Run("should error when attempting to use a cursor with a query", func(t *testing.T) { + t.Run("should allow passing a cursor with a query", func(t *testing.T) { query, queryErr := fauna.FQL(`EventFeedTest.all().eventSource()`, nil) require.NoError(t, queryErr, "failed to create a query for EventSource") - _, feedErr := client.FeedFromQuery(query, fauna.EventFeedCursor("cursor")) - require.ErrorContains(t, feedErr, "cannot use EventFeedCursor with FeedFromQuery") + feed, feedErr := client.FeedFromQuery(query, fauna.EventFeedCursor("cursor")) + require.NoError(t, feedErr, "failed to init events feed") + require.NotNil(t, feed, "feed is nil") }) t.Run("should error when attempting to use a start time and a cursor", func(t *testing.T) {