Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note element width wants to be dynamic #1

Open
aaron-em opened this issue Mar 9, 2016 · 1 comment
Open

Note element width wants to be dynamic #1

aaron-em opened this issue Mar 9, 2016 · 1 comment

Comments

@aaron-em
Copy link

aaron-em commented Mar 9, 2016

responsive oops
window.innerWidth is 1110px.

From poking at it, it looks like the margin note declines to display itself if it would have a width of less than 60px, but there's some slack between that minimum and wide enough to display content without having it cut off by the edge of the viewport. Perhaps it'd be desirable to check before rendering whether there's enough horizontal space to fit the element, and if not, to overlay it on the content in the style of a tooltip or otherwise provide some sort of fallback.

Just a thought, anyway; I noticed and figured I'd mention. It's a nifty little library in general; nice work!

@fdansv
Copy link
Owner

fdansv commented Mar 9, 2016

Yes, this is totally a todo. For the sake of not complicating myself too much at the beginning, I just limited rendering whenever there's some real estate for the note to show correctly. A tooltip over the element makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants