Handle avifDecoderCreate and avifEncoderCreate errors #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
libavif-plugin
branch
from
7e66fb2 to
e649070
Compare
|
As far as the commit from which the PR's title is taken: libavif has only limited max threads since 1.1.0 (see the discussion here). This was actually added to pillow-avif-plugin in response to a bug report: fdintino/pillow-avif-plugin#23. We should probably document a new minimum version if we want to require it. (edit: the version was actually 1.1.0, not 1.0.2) |
radarhere
force-pushed
the
libavif-plugin
branch
from
e649070 to
56f8551
Compare
radarhere
changed the title
|
Ok, thanks - I've removed that commit. |
fdintino
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions for python-pillow#5201
Looking at https://github.com/AOMediaCodec/libavif/blob/906a8a5bd18a744f0e2e603e1841c1ef5e712677/src/codec_aom.c#L749-L753, I found that libavif limits the number of threads in aom itself - so there should be no need for our code to also limit it to 64.