Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI lint secrets permission error and macOS GHA runner homebrew PATH bug #55

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Fix CI lint secrets permission error and macOS GHA runner homebrew PATH bug #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
014456c
fix(ci): use GITHUB_TOKEN instead of secret to allow external PR lint
fdintino Jul 3, 2024
33cdaf3
fix(ci): deal with gha macos homebrew symlink bug
fdintino Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ jobs:
- name: Set environment variables
run: |
echo "REPORTER=${{ github.event_name == 'pull_request' && 'github-pr-review' || 'github-check' }}" >> $GITHUB_ENV
echo "REVIEWDOG_GITHUB_API_TOKEN=${{ secrets.REVIEWDOG_GITHUB_API_TOKEN }}" >> $GITHUB_ENV
echo "REVIEWDOG_TOKEN=${{ secrets.REVIEWDOG_TOKEN }}" >> $GITHUB_ENV
echo "REVIEWDOG_GITHUB_API_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV

- name: clang-format
uses: DoozyX/[email protected]
Expand All @@ -34,14 +33,14 @@ jobs:
- name: flake8
uses: reviewdog/action-flake8@v3
with:
github_token: ${{ secrets.REVIEWDOG_GITHUB_API_TOKEN }}
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: ${{ env.REPORTER }}
filter_mode: nofilter

- name: black
uses: reviewdog/action-black@v3
with:
github_token: ${{ secrets.REVIEWDOG_GITHUB_API_TOKEN }}
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: ${{ env.REPORTER }}
filter_mode: nofilter

7 changes: 6 additions & 1 deletion .github/workflows/macos-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@

set -e

brew reinstall cmake
# See https://github.com/actions/runner-images/issues/9471 for why we have
# brew unlink and brew link commands here
brew unlink cmake || true
brew reinstall cmake || true
brew link --overwrite cmake

brew install dav1d aom rav1e

if [ "$GHA_PYTHON_VERSION" == "2.7" ]; then
Expand Down
Loading