Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newlines properly in ModuleWriter #93

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Add newlines properly in ModuleWriter #93

merged 3 commits into from
Nov 27, 2024

Conversation

Y-Nak
Copy link
Collaborator

@Y-Nak Y-Nak commented Nov 27, 2024 •
edited
Loading

@sbillig Sorry, I forgot to include this fix in #85.

  • Rename Module::funcs -> Module::func_store
  • Insert newlines properly between declarations
  • Fix InstWrite impl for EvmContractSize/GetFunctionPtr

Regarding to InstWrite macro, I'll tweak impl_inst_write macro a little bit in another PR.

@Y-Nak Y-Nak requested a review from sbillig November 27, 2024 10:46
sbillig
sbillig approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbillig sbillig merged commit 4510679 into fe-lang:main Nov 27, 2024
10 checks passed
@Y-Nak Y-Nak deleted the tweak-ir-writer branch November 28, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillig sbillig sbillig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Y-Nak @sbillig