Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate hook includes data from wrong db service when using a custom query in find #254

Closed
RobIsHere opened this issue Sep 14, 2017 · 3 comments

Comments

@RobIsHere
Copy link

I made an issue here feathersjs-ecosystem/feathers-knex#117
but that affects also other dbs, because it is an issue of params being simply forwarded.

I think that sequelize is also affected in a similar way with its params.sequelize being forwarded and applied, see:
https://github.com/feathersjs/feathers-sequelize/blob/master/src/index.js#L48

@eddyystop
Copy link
Collaborator

Am I correct in assuming you've posted this issue here mainly for informational purposes? Though serious, this does not been to be an issue with populate itself.

@RobIsHere
Copy link
Author

I discovered it using populate but you are right it's a more general issue. It's just here to spare other devs some time. And get some attention of someone who has a plan for a fix ;)

@daffl
Copy link
Member

daffl commented Sep 18, 2017

I'm going to close this one since I think we should try and solve this with the Knex adapter first which is tracked in feathersjs-ecosystem/feathers-knex#117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants