Skip to content

Commit bb3f9e8

Browse files
authored
fix: capital usernames and project names break URL detection (#256)
1 parent 1eedeb2 commit bb3f9e8

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.github/pull_request_template.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ If your changes involve documentation updates please mention that and link the a
1919

2020
To run this pull request in a clean container visit:
2121
1. Visit https://replit.com/new/github/feathersjs/feathers-chat
22-
2. Run `git pull origin pull/{{id}}/head`
22+
2. Run git pull origin pull/{{id}}/head
2323

2424
Thanks for contributing to Feathers! :heart:

.replit

+3-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ npm run dev
88
compile = """ # Runs before debug too. Lacks custom env vars.
99
SECONDS=0
1010
FEATHERS_DIR="feathers-chat-ts"
11-
FEATHERS_ORIGIN="https://$REPL_SLUG.$REPL_OWNER.repl.co"
11+
FEATHERS_ORIGIN="https://${REPL_SLUG,,}.${REPL_OWNER,,}.repl.co"
1212
clear
1313
echo [compile]
1414

@@ -57,7 +57,7 @@ fi
5757
INDEX_TS="$FEATHERS_DIR/src/index.ts"
5858
if ! grep -q "console.time" "$INDEX_TS"; then
5959
sed -i "/Feathers app listening on /a \\
60-
\\ logger.info(\\`Remote: \\${process.env.FEATHERS_ORIGIN}\\`)\\n\\
60+
\\ logger.info(\\`Remote: \\${process.env.FEATHERS_ORIGIN?.toLowerCase()}\\`)\\n\\
6161
console.timeEnd('App startup time')" "$INDEX_TS"
6262

6363
sed -i "1i console.time('App startup time')" "$INDEX_TS"
@@ -93,7 +93,7 @@ PATH = "/home/runner/$REPL_SLUG/.config/npm/node_global/bin:/home/runner/$REPL_S
9393
EDITOR = "replit-git-editor"
9494
npm_config_prefix = "/home/runner/$REPL_SLUG/.config/npm/node_global"
9595
HOSTNAME = "0.0.0.0"
96-
FEATHERS_ORIGIN = "https://$REPL_SLUG.$REPL_OWNER.repl.co"
96+
FEATHERS_ORIGIN = "https://${REPL_SLUG}.${REPL_OWNER}.repl.co"
9797
NODE_OPTIONS = "--max_old_space_size=384"
9898

9999
# Enables Secrets and Auth, without the Replit packager
@@ -153,5 +153,4 @@ support = true
153153

154154
[debugger.interactive.launchMessage.arguments.env]
155155
PORT = 9000
156-
FEATHERS_ORIGIN = "https://$REPL_SLUG.$REPL_OWNER.repl.co:9000"
157156

0 commit comments

Comments
 (0)