New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix class design inconsistency for `HistoryMonitor` #491

Open

srcansiz opened this issue Mar 13, 2023 · 0 comments

Labels

candidate good first issue

Member

srcansiz commented Mar 13, 2023

In GitLab by @mvesin on Mar 13, 2023, 14:28

As a developper I want class design inconsistency for HistoryMonitor to be fixed.

The issue:

HistoryMonitor is defined as part of node (fedbiomed.node.history_monitor.HistoryMonitor)
but it is also used by some modules in common (fedbiomed.common.training_plans)

A possible solution:

a stub (null payload) common.HistoryMonitor
a subclass node.NodeHistoryMonitor(HistoryMonitor) with the payload of actual history monitor
use common.HistoryMonitor in common
if needed, add additional checks in common ? (should not be necessary)

Dear user, please keep the lign below when submitting an issue:

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment