Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Propose new metadata" button disabled #554

Open
hensg opened this issue Oct 3, 2024 · 2 comments
Open

"Propose new metadata" button disabled #554

hensg opened this issue Oct 3, 2024 · 2 comments

Comments

@hensg
Copy link
Contributor

hensg commented Oct 3, 2024

I'm running a "Solo Mode Federation" and would like to change the name of my federation. However, the "Propose new metadata" button is disabled. Should it really say "Propose," considering the federation is in Solo Mode? Wouldn't "Update metadata" make more sense? It feels odd to "propose" something when there's no one to propose it to.

image

@hensg
Copy link
Contributor Author

hensg commented Oct 3, 2024

Actually, it was enabled after entering the federation icon URL. Is it really required?

@hensg hensg changed the title Propose new meta disabled in Solo Mode "Propose new metadata" button disabled Oct 3, 2024
@kleyberthsantos
Copy link
Contributor

I see that the "Propose New Metadata" label is generalized for both multi-guardian and single-guardian federations.

  • Do you suggest that "Update Metadata" be a change to the button label or that logic be added so that the change from "Propose New Metadata" to "Update Metadata" is only available in Solo Mode Federation?

  • The button is enabled as long as all fields are filled, and it also checks that the Icon url is an image, would you like the button to keep the same logic but be enabled without the Icon url?

If the answer is yes, I'd liked to say I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants