Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse site config from fivefilters site-config? #154

Open
kossmoboleat opened this issue May 12, 2020 · 5 comments
Open

Reuse site config from fivefilters site-config? #154

kossmoboleat opened this issue May 12, 2020 · 5 comments
Assignees

Comments

@kossmoboleat
Copy link

Just an idea/feature request:
Would it be possible to convert site-configs from https://github.com/fivefilters/ftr-site-config?

These already contain a lot of sites and very well made settings.

@dugite-code
Copy link
Contributor

dugite-code commented May 13, 2020

I don't see why we couldn't, it looks to be a rather simple format that has a fair amount in common with our project. https://help.fivefilters.org/full-text-rss/site-patterns.html#pattern-format

  • body is a simple xpath
  • strip is just a cleanup xpath
  • strip_id_or_class could be converted to a cleanup xpath
  • strip_image_src could be converted to a cleanup xpath
  • tidy Boolean aligns with our own tidy option
  • single_page_link is multipage with recursive set to false
  • next_page_link is multipage with recursive set to true
  • replace_string is modify with replace
  • title, date and author can probably be ignored
  • prune incompatible with our set-up
  • autodetect_on_failure incompatible with our set-up

@GoodSoulGermany
Copy link
Contributor

Awesome idea, thanks for sharing @kossmoboleat. I will reuse these on other projects as well.

Btw: Any progress on this?

@dugite-code
Copy link
Contributor

dugite-code commented Aug 19, 2020

@GoodSoulGermany I had written a very basic parser but lost my work. But that was fairly simple to do. The difficulty is figuring out how to elegantly display the ability to add said filters.

I was already thinking of adding a category drop-down to the configuration tab's recipe import, so I might just stick it there.

*Edit: Although it is over 1000 entry's long so some form of search may be necessary

@dugite-code
Copy link
Contributor

dugite-code commented Aug 28, 2020

Work started, with the parser finished: https://github.com/feediron/ttrss_plugin-feediron/blob/dev/preftab/fi_fivefilters.php

Just need to integrate it with the recipe manager

@dugite-code dugite-code self-assigned this Aug 28, 2020
@dugite-code dugite-code pinned this issue Aug 28, 2020
@dugite-code
Copy link
Contributor

cookies/headers support needs to be added as part of the retriever work #44 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants