Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where series values having spaces and invalid characters would invalidate class names #48

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

DiogoRDuarte
Copy link
Contributor

Summary

Because

While implementing a multi-series chart, the values of the chosen series key couldn't have spaces and invalid characters in them. This is an issue since these values are eventually converted to class names and spaces in them means having different classes.

This Commit

  • Fixed an issue where series values having spaces or invalid characters would invalidate class names. The multi-series implementation experience remains intact with the addition of being possible to have spaces and invalid characters in the series strings.
  • Removes leftover console logs from the examples;
  • Removed repeated titles and chart types from the shorter and longer manual descriptions;

image

@DiogoRDuarte DiogoRDuarte self-assigned this Jan 6, 2025
@DiogoRDuarte DiogoRDuarte merged commit 86c05e9 into releases Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant