Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LightGBM models locale sensitivity and improve R/W performance. #3

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
[submodule "include/boost/compute"]
path = compute
url = https://github.com/boostorg/compute
[submodule "external_libs/fmt"]
path = external_libs/fmt
url = https://github.com/fmtlib/fmt.git
[submodule "external_libs/fast_double_parser"]
path = external_libs/fast_double_parser
url = https://github.com/lemire/fast_double_parser.git
5 changes: 5 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,11 @@ if(__BUILD_FOR_R)
endif(MSVC)
endif(__BUILD_FOR_R)

# fmtlib/fmt
add_subdirectory(external_libs/fmt)
TARGET_LINK_LIBRARIES(lightgbm PUBLIC fmt::fmt)
TARGET_LINK_LIBRARIES(_lightgbm PUBLIC fmt::fmt)

install(TARGETS lightgbm _lightgbm
RUNTIME DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/lib
Expand Down
1 change: 1 addition & 0 deletions external_libs/fast_double_parser
Submodule fast_double_parser added at 98c751
1 change: 1 addition & 0 deletions external_libs/fmt
Submodule fmt added at 2e620d
Loading