Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4

Merged
merged 219 commits into from
Aug 14, 2023
Merged

Develop #4

merged 219 commits into from
Aug 14, 2023

Conversation

felipecastrosales
Copy link
Owner

Related to #1.

@gitguardian
Copy link

gitguardian bot commented Aug 11, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
5808922 Google API Key bd170c9 ios/Runner/GoogleService-Info.plist View secret
5808922 Google API Key bd170c9 macos/Runner/GoogleService-Info.plist View secret
5808922 Google API Key 4ac4872 ios/Runner/GoogleService-Info.plist View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@b81a54e). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   79.41%           
=========================================
  Files             ?       85           
  Lines             ?     1103           
  Branches          ?        0           
=========================================
  Hits              ?      876           
  Misses            ?      227           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felipecastrosales felipecastrosales merged commit 932ba45 into master Aug 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant