Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migracion Fondos y Ctas remuneradas ArgentinaDatos #36 #72

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

FacuMasino
Copy link
Collaborator

Siguiendo los pasos del Issue #36 ahora se obtiene la información de los FCI de la Api ArgentinaDatos, queda pendiente:

  • Agregar Naranja X, por el momento no está en la API
  • CryptoPesos y BuenDolar se sigue consumiendo desde Supabase, se podría optimizar el fetch de supabase quitando la información que no se usa y dejando solo esos 2 o obtenerlo de otra API.

Cualquier revisión, cambio/sugerencia es bienvenida 🙂

resolves #36

Copy link

stackblitz bot commented Feb 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Feb 26, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @ferminrp on Vercel.

@ferminrp first needs to authorize it.

@FacuMasino FacuMasino changed the base branch from main to develop February 26, 2024 22:10
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
compara-tasas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 11:19am

@@ -37,12 +38,12 @@ const MenuDropdown = ({ pathname }: { pathname: string }) => {
{isOpen && (
<div
ref={menuRef}
className='w-[50%] min-w-[200px] max-w-[300px] flex flex-col rounded-lg border-[#CAD0E0] dark:border-[#292B2E] border-[1px] bg-white dark:bg-gray-900 absolute top-0 right-0'
className='absolute right-0 top-0 flex w-[50%] min-w-[200px] max-w-[300px] flex-col rounded-lg border-[1px] border-[#CAD0E0] bg-white dark:border-[#292B2E] dark:bg-gray-900'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aclaración: No se cambió nada del diseño, pero al cambiar el atributo type del botón y la prop Key de MenuItem, cuándo guardé el archivo el plugin de prettier re-ordenó las clases

@ferminrp ferminrp merged commit abaecf5 into ferminrp:develop Feb 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrar fuente de información de fondos y cuentas remuneradas a ArgentinaDatos
2 participants