From 353d26d91f1462cb0d723476cb09a46121e89c9c Mon Sep 17 00:00:00 2001 From: Deep Singhvi Date: Sat, 4 May 2024 22:23:39 -0500 Subject: [PATCH] (improvment): fdr cdk accepts memory and cpu parameters (#799) --- servers/fdr-deploy/bin/fdr-deploy.ts | 4 ++++ servers/fdr-deploy/scripts/fdr-deploy-stack.ts | 9 +++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/servers/fdr-deploy/bin/fdr-deploy.ts b/servers/fdr-deploy/bin/fdr-deploy.ts index 1b666ae947..d2fc70c81e 100644 --- a/servers/fdr-deploy/bin/fdr-deploy.ts +++ b/servers/fdr-deploy/bin/fdr-deploy.ts @@ -30,6 +30,8 @@ async function main() { desiredTaskCount: 2, maxTaskCount: 4, redis: true, + memory: 1024, + cpu: 512, }, { env: { account: "985111089818", region: "us-east-1" }, @@ -47,6 +49,8 @@ async function main() { desiredTaskCount: 1, maxTaskCount: 1, redis: false, + memory: 8192, + cpu: 4096, }, { env: { account: "985111089818", region: "us-east-1" }, diff --git a/servers/fdr-deploy/scripts/fdr-deploy-stack.ts b/servers/fdr-deploy/scripts/fdr-deploy-stack.ts index 68921dc3ec..7dd3b0feed 100644 --- a/servers/fdr-deploy/scripts/fdr-deploy-stack.ts +++ b/servers/fdr-deploy/scripts/fdr-deploy-stack.ts @@ -36,6 +36,8 @@ interface FdrStackOptions { redis: boolean; maxTaskCount: number; desiredTaskCount: number; + cpu: number; + memory: number; } export class FdrDeployStack extends Stack { @@ -118,12 +120,11 @@ export class FdrDeployStack extends Stack { hostedZoneId: environmentInfo.route53Info.hostedZoneId, zoneName: environmentInfo.route53Info.hostedZoneName, }); - const redisEnabled = environmentType !== "PROD"; const fargateService = new ApplicationLoadBalancedFargateService(this, SERVICE_NAME, { serviceName: SERVICE_NAME, cluster, - cpu: environmentType === "PROD" ? 4096 : 512, - memoryLimitMiB: environmentType === "PROD" ? 8192 : 1024, + cpu: options.cpu, + memoryLimitMiB: options.memory, desiredCount: options.desiredTaskCount, securityGroups: [fdrSg, efsSg], taskImageOptions: { @@ -143,7 +144,7 @@ export class FdrDeployStack extends Stack { LOG_LEVEL: getLogLevel(environmentType), DOCS_CACHE_ENDPOINT: fernDocsCacheEndpoint, ENABLE_CUSTOMER_NOTIFICATIONS: (environmentType === "PROD").toString(), - REDIS_ENABLED: redisEnabled.toString(), + REDIS_ENABLED: options.redis.toString(), APPLICATION_ENVIRONMENT: getEnvironmentVariableOrThrow("APPLICATION_ENVIRONMENT"), }, containerName: CONTAINER_NAME,