From d4cb0e822184277de5e9da92c6db16435ad614b7 Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Thu, 30 Nov 2023 22:17:17 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20post-p?= =?UTF-8?q?rocessor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- samples/createSubscriptionWithDeadLetterPolicy.js | 1 - samples/createSubscriptionWithExactlyOnceDelivery.js | 1 - samples/createSubscriptionWithOrdering.js | 1 - samples/publishAvroRecords.js | 1 - samples/publishMessage.js | 1 - samples/publishProtobufMessages.js | 1 - samples/publishWithRetrySettings.js | 1 - 7 files changed, 7 deletions(-) diff --git a/samples/createSubscriptionWithDeadLetterPolicy.js b/samples/createSubscriptionWithDeadLetterPolicy.js index 5839ec0ca..708efc18a 100644 --- a/samples/createSubscriptionWithDeadLetterPolicy.js +++ b/samples/createSubscriptionWithDeadLetterPolicy.js @@ -61,7 +61,6 @@ async function createSubscriptionWithDeadLetterPolicy( console.log( `Created subscription ${subscriptionNameOrId} with dead letter topic ${deadLetterTopicNameOrId}.` ); - console.log( 'To process dead letter messages, remember to add a subscription to your dead letter topic.' ); diff --git a/samples/createSubscriptionWithExactlyOnceDelivery.js b/samples/createSubscriptionWithExactlyOnceDelivery.js index f28c0df91..6bbcb1422 100644 --- a/samples/createSubscriptionWithExactlyOnceDelivery.js +++ b/samples/createSubscriptionWithExactlyOnceDelivery.js @@ -55,7 +55,6 @@ async function createSubscriptionWithExactlyOnceDelivery( console.log( `Created subscription ${subscriptionNameOrId} with exactly-once delivery.` ); - console.log( 'To process messages, remember to check the return value of ackWithResponse().' ); diff --git a/samples/createSubscriptionWithOrdering.js b/samples/createSubscriptionWithOrdering.js index 92e432ca1..933260704 100644 --- a/samples/createSubscriptionWithOrdering.js +++ b/samples/createSubscriptionWithOrdering.js @@ -55,7 +55,6 @@ async function createSubscriptionWithOrdering( console.log( `Created subscription ${subscriptionNameOrId} with ordering enabled.` ); - console.log( 'To process messages in order, remember to add an ordering key to your messages.' ); diff --git a/samples/publishAvroRecords.js b/samples/publishAvroRecords.js index a4460b3c1..f40f3e418 100644 --- a/samples/publishAvroRecords.js +++ b/samples/publishAvroRecords.js @@ -80,7 +80,6 @@ async function publishAvroRecords(topicNameOrId) { console.log(`Unknown schema encoding: ${schemaEncoding}`); break; } - if (!dataBuffer) { console.log(`Invalid encoding ${schemaEncoding} on the topic.`); return; diff --git a/samples/publishMessage.js b/samples/publishMessage.js index beccf0fd4..2436b07fb 100644 --- a/samples/publishMessage.js +++ b/samples/publishMessage.js @@ -54,7 +54,6 @@ async function publishMessage(topicNameOrId, data) { console.log(`Message ${messageId} published.`); } catch (error) { console.error(`Received error while publishing: ${error.message}`); - process.exitCode = 1; } } diff --git a/samples/publishProtobufMessages.js b/samples/publishProtobufMessages.js index 9ef309359..bab100563 100644 --- a/samples/publishProtobufMessages.js +++ b/samples/publishProtobufMessages.js @@ -82,7 +82,6 @@ async function publishProtobufMessages(topicNameOrId) { console.log(`Unknown schema encoding: ${schemaEncoding}`); break; } - if (!dataBuffer) { console.log(`Invalid encoding ${schemaEncoding} on the topic.`); return; diff --git a/samples/publishWithRetrySettings.js b/samples/publishWithRetrySettings.js index 088673224..3c50b5a99 100644 --- a/samples/publishWithRetrySettings.js +++ b/samples/publishWithRetrySettings.js @@ -45,7 +45,6 @@ const {v1} = require('@google-cloud/pubsub'); const publisherClient = new v1.PublisherClient({ // optional auth parameters }); - async function publishWithRetrySettings(projectId, topicNameOrId, data) { const formattedTopic = publisherClient.projectTopicPath( projectId,