Skip to content

Commit

Permalink
rpmcli.h forces a public dependency on popt includes
Browse files Browse the repository at this point in the history
This is mildly annoying, librpm users don't need to link to popt but
this one include in rpmcli.h (that most API users wont even use) forces
a public dependency on it.

Another possibility could be splitting out the "cli" part of librpm
one way or another, but that doesn't seem worth all the trouble it would
be.
  • Loading branch information
pmatilai committed Jan 8, 2024
1 parent dbd5307 commit 75965c1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ target_include_directories(librpm PRIVATE
${CMAKE_CURRENT_BINARY_DIR}
${Intl_INCLUDE_DIRS}
)
# This is needed for rpmcli.h
target_include_directories(librpm PUBLIC ${POPT_INCLUDE_DIRS})

target_sources(librpm PRIVATE
backend/dbi.c backend/dbi.h backend/dummydb.c
Expand Down

0 comments on commit 75965c1

Please sign in to comment.