Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional peaksData columns? #16

Open
jorainer opened this issue Apr 11, 2022 · 3 comments
Open

Additional peaksData columns? #16

jorainer opened this issue Apr 11, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jorainer
Copy link
Collaborator

Looking at the code of peaksData,MsBackendRawFileReader it looks like you can extract more than just m/z and intensity values from the raw data files. Is that correct?

@cpanse
Copy link
Collaborator

cpanse commented May 17, 2022

@jorainer yes; the plan is using rawrr::readTrailer

https://github.com/fgcz/rawrr/blob/1b0ac1c5e79574fdcb75df63bab7b41f8291d8a0/R/rawrr.R#L1434

with that, any trailer information can be retrieved.

it just has to be implemented.

@cpanse cpanse self-assigned this May 17, 2022
@cpanse cpanse added the enhancement New feature or request label May 17, 2022
@jorainer
Copy link
Collaborator Author

Note that we have added an additional parameter columns to the peaksData method (https://github.com/rformassspectrometry/Spectra/blob/master/R/MsBackend.R#L735-L738). This would the user to define which columns/data to retrieve for peaks. The default is c("mz", "intensity") but, depending on the backend, also others could now be supported. As a result a numeric matrix with the additional columns would be returned.

The peaksVariables method (https://github.com/rformassspectrometry/Spectra/blob/master/R/MsBackend.R#L742-L745) would allow to show the supported columns to the user. The MsBackendTimsTOF already uses this (https://github.com/rformassspectrometry/MsBackendTimsTof/blob/main/R/MsBackendTimsTof.R#L181-L196).

@cpanse
Copy link
Collaborator

cpanse commented Mar 9, 2023

@jorainer #19 seems to be a start. whatsoever here, we use, of course, Spectra::spectraVariables. Possible columns for peaksData could be charge and resolution as displayed in Figure 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants