-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readSpectrum(...) #2
Comments
Potentially interesting:
contains attributes like
contains attributes like The BIG question: How much scan meta data do we want to extract by default??? |
complete scan header example c&p from Freestyle:
|
|
Hi CP, I checked the details of the current implementation. Currently, some important items are missing in the list/S3 object returned by *Total Ion Current further down the list you should also see a key:value pair Regarding those key:value pairs that are used by thermo to structure the list. Would it be possible to use them as branch points for nesting the list in R?
And we should think about where to place the peak lists/attributes in the returned object! The basic peak list is two numeric vectors: *position (mz) but there should be additional vectors like: resolution, noise, charge, background and the peak flags. As discussed before, maybe having a dedicated object for the peak lists would help, since the vectors would need to stick to certain names, be of equal length and types. What do you think?
|
After reading the S3 OOP chapter in Master Hadleys book of whisdom I realized the following: ˋreadSpectrum()ˋ is equal to one of the 3 essential functions, the ˋmyclass()ˋor helper function in case users create class instances. I would therefore rename ˋreadSpectrum()ˋ to ˋSpectrumˋ |
Or if we incl. the package name in the object name as you suggest ˋrawRSpectrum()ˋ |
See section 13.3.3 of Hadleys book of wisdom. |
13.3.3 also answers your question regarding the usage of the validator. The helper function calls the low level constructor ˋnew_myclass() and the validator. |
The final goal should be that people only interact with two well crafted objects: rawRSpectrum and rawRChromatogram |
no idea what is meant with helper in that context
…On Thu, Sep 17, 2020 at 10:09 AM Tobias Kockmann ***@***.***> wrote:
13.3.3 also answers your question regarding the usage of the validator.
The helper function calls the low level constructor ˋnew_myclass() and the
validator.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFMYY76XKJFOE6J7OTVSGLSGG74JANCNFSM4QKNXNOA>
.
|
ahh |
brain wash |
Something I came across:
it returns a plain list instead of a Could you fix that @cpanse ??? |
status quo: only peak flags are missing. |
refactor
rawDiag::readScans()
arguments
rawfile : path to raw file
scans : numeric vector for selection based on scan index
filter : scan filter for logical selection of scans (e.g. MS, MS2, +, HCD, ...)
returns
S3 object, nested list of type Spectrum (not
peaklist
)for
FTMS
scans the list should contain vectors for: mz, intensity, resolution, noise, chargeIn addition header information is needed:
The text was updated successfully, but these errors were encountered: