Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readDetectorList(...) and details #4

Open
tobiasko opened this issue Aug 28, 2020 · 3 comments
Open

readDetectorList(...) and details #4

tobiasko opened this issue Aug 28, 2020 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@tobiasko
Copy link
Collaborator

Each raw file header contains a detector list. c# methods are:

int GetInstrumentCountOfType (Device type)

Device GetInstrumentType(int index);

int InstrumentCount { get; }

see page 17 of UsingRawFileReader.

details are available through InstrumentData GetInstrumentData();

@tobiasko
Copy link
Collaborator Author

tobiasko commented Sep 2, 2020

This issue directly connects to #1, since our current code reads always from the detector type MS. If we would like to support other detector types in the future details about those become necessary.

cpanse added a commit that referenced this issue Sep 8, 2020
@cpanse cpanse added the help wanted Extra attention is needed label Sep 9, 2020
@BerndMaier
Copy link

Hi there, just wanted to thank both of you again for the awesome work.
I just wanted to check if there is any progress about reading other detector types (UV, Pump Pressure) out of Thermo Raw Files.

We recently had some bigger issues with Vanquish retention time shifts, clearly linked to the pump pressure.
Which could be nicely checked if the data would be accessible.

So keep up the great work 👍
Bernd

@tobiasko
Copy link
Collaborator Author

Hi @BerndMaier, we unfortunately haven't worked on this issue yet. Currently, we are pushing to get rawrr submitted to bioc (which turned out to be more complicated than expected). But I am still hoping that we will also support other detectors in the future. We also welcome help, since this is mainly work on the C# code. So all the protinf c# nerds out there this is your chance to contribute!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants