Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method ambiguity on Julia v1.11 #108

Open
sethaxen opened this issue Aug 29, 2024 · 0 comments
Open

New method ambiguity on Julia v1.11 #108

sethaxen opened this issue Aug 29, 2024 · 0 comments

Comments

@sethaxen
Copy link

On Julia v1.11-rc3, there's a new ambiguity in the method for write that is not present on v1.10.5:

julia> using Aqua, ZipFile

julia> Aqua.test_ambiguities(ZipFile)
1 ambiguities found. To get a list, set `broken = false`.
Ambiguity #1
write(w::ZipFile.Zlib.Writer, a::SubArray{T, N, A}) where {T, N, A<:Array} @ ZipFile.Zlib ~/.julia/packages/ZipFile/yQ7yx/src/Zlib.jl:169
write(s::IO, A::StridedArray) @ Base io.jl:833

Possible fix, define
  write(::ZipFile.Zlib.Writer, ::SubArray{T, N, A, I} where I<:Tuple{Vararg{Union{Base.AbstractCartesianIndex, AbstractRange{<:Union{Int128, Int16, Int32, Int64, Int8, UInt128, UInt16, UInt32, UInt64, UInt8}}, Base.ReshapedArray{T, N, A, Tuple{}} where {T, N, A<:AbstractUnitRange}, Int128, Int16, Int32, Int64, Int8, UInt128, UInt16, UInt32, UInt64, UInt8}}}) where {T, N, A<:Array}

Skipping ZipFile.Zlib.compress
Skipping ZipFile.Zlib.decompress
Test Failed at /home/sethaxen/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:78
  Expression: iszero(num_ambiguities)

ERROR: There was an error during testing

Version info

julia> versioninfo()
Julia Version 1.11.0-rc3
Commit 616e45539db (2024-08-26 15:46 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, tigerlake)
Threads: 8 default, 0 interactive, 4 GC (on 8 virtual cores)
Environment:
  JULIA_NUM_THREADS = auto
  JULIA_EDITOR = code

julia> using Pkg; Pkg.status()
Status `/tmp/jl_E0YQla/Project.toml`
  [4c88cf16] Aqua v0.8.7
  [a5390f91] ZipFile v0.10.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant