Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__init__.py:1: Implement Page, PaginatedProducts,... #207

Closed
0pdd opened this issue Nov 4, 2018 · 6 comments
Closed

__init__.py:1: Implement Page, PaginatedProducts,... #207

0pdd opened this issue Nov 4, 2018 · 6 comments
Assignees
@ArtemijRodionov
Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable Context feature report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Nov 4, 2018

The puzzle 183-d6341b3e from #183 has to be resolved:

refarm-site/catalog/context/__init__.py

Line 1 in fb2fa2a

# @todo #183:120m Implement Page, PaginatedProducts, ProductBrands, ProductsImages context classes.

The puzzle was created by Artemiy on 04-Nov-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Nov 4, 2018
@ArtemijRodionov
#183 object compositions (#194)
fb2fa2a 
* Create catalog.context package

* Create context package

* Specify context ABS classes

* Implement base product contexts classes

* Implement base tag contexts classes

* Resolve todo and create another one for  ordering arg

* Self-review fixes

* Review fixes

* Self-review fixes
@0pdd 0pdd mentioned this issue Nov 4, 2018
Closed
@ArtemijRodionov ArtemijRodionov added 2 hours some big and monolith issues. For example with hard decisions or discussions 1 burning issue cleanup everything that do project stronger, flexible, reusable labels Nov 4, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Nov 4, 2018
@ArtemijRodionov ArtemijRodionov mentioned this issue Nov 9, 2018
Merged
ArtemijRodionov added a commit that referenced this issue Nov 13, 2018
@ArtemijRodionov
#207 Context classes (#212)
4b333aa 
* Implement ProductBrands class

* Implement ProductImages class

* Create tests: ProductsContext and TagsContext. Fix a lot of code.

* Apply the review's fixes
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Nov 13, 2018
@0pdd 0pdd mentioned this issue Nov 13, 2018
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Nov 13, 2018

@0pdd the puzzle #213 is still not solved.

@duker33 duker33 added the Context feature label Dec 31, 2018
This was referenced Dec 31, 2018
Closed
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 31, 2018

@0pdd 3 puzzles #239, #240, #241 are still not solved; solved: #213.

@0pdd
Copy link
Collaborator Author

0pdd commented Feb 14, 2019

@0pdd 6 puzzles #239, #240, #241, #267, #268, #269 are still not solved; solved: #213.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 15, 2019

@0pdd 4 puzzles #239, #267, #268, #269 are still not solved; solved: #213, #240, #241.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 16, 2019

@0pdd 3 puzzles #239, #268, #269 are still not solved; solved: #213, #240, #241, #267.

@0pdd
Copy link
Collaborator Author

0pdd commented Apr 3, 2019

@0pdd 2 puzzles #239, #269 are still not solved; solved: #213, #240, #241, #267, #268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable Context feature report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd