Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context.py:4-8: Improve PaginationContext interface.... #266

Closed
0pdd opened this issue Feb 14, 2019 · 1 comment
Closed

context.py:4-8: Improve PaginationContext interface.... #266

0pdd opened this issue Feb 14, 2019 · 1 comment
Labels
2 performer can implement issue at his closest convenient time 30 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable Context feature take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented Feb 14, 2019

The puzzle 255-b02f6e0d from #255 has to be resolved:

refarm-site/refarm_pagination/context.py

Lines 4 to 8 in e37f7f8

# @todo #255:30m Improve `PaginationContext` interface.
# It's not clear now.
# For example client should know the class context details
# to fetch objects iterable.
# See `catalog.newcontext.products.PaginatedProducts#qs`.

The puzzle was created by duker33 on 14-Feb-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Feb 14, 2019
@duker33
#255 Move products context to the QS (#263)
e37f7f8 
* #255  PDD task to fix bad settings entry

* #255  Move part of products context to the qs

* rf#255  Remove redundant tests

* #240  Fix CI
@0pdd 0pdd mentioned this issue Feb 14, 2019
Closed
@duker33 duker33 added 30 mins small issues. Usually cosmetic fixes 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it Context feature labels Feb 14, 2019
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 15, 2019

The puzzle 255-b02f6e0d has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Mar 15, 2019
0pdd referenced this issue Mar 15, 2019
@duker33
#set of minor fixes (#307)
0727201 
* stb#447  Move Request class to the refarm side

* stb#450  Create ContextDict type at refarm side

* stb#444  Move catalog Page to refarm side

* #fix  Context recursive imports

* #fix  Context recursive imports

# Conflicts:
#	catalog/newcontext/__init__.py

* rf#260  Rename "newcontext" to "context"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 performer can implement issue at his closest convenient time 30 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable Context feature take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd