Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models.py:226-227: Resolve slug code doubling. See... #306

Open
0pdd opened this issue Mar 6, 2019 · 1 comment
Open

models.py:226-227: Resolve slug code doubling. See... #306

0pdd opened this issue Mar 6, 2019 · 1 comment
Labels
3 we can defer this issue. But it'll good to implement it 30 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable hard issue requires strong architecture skills, management skills, project domain area, etc take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 6, 2019

The puzzle 302-40867787 from #302 has to be resolved:

refarm-site/catalog/models.py

Lines 226 to 227 in d659d42

# @todo #302:30m Resolve slug code doubling.
# See `TagGroup.slug` and `Tag._get_slug`.

The puzzle was created by duker33 on 06-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Mar 6, 2019
@duker33
#302 Slugify tags with theirs groups (#304)
d659d42 
* #302  Pdd task for more good processing request symbols for slugs

* #302  Add group part to tag slugs

* #302  Fix tests

* #302  Review#1 minor fixes

* #302  Fix test
@0pdd 0pdd mentioned this issue Mar 6, 2019
Closed
@duker33 duker33 assigned duker33 and unassigned duker33 Mar 6, 2019
@duker33 duker33 added 30 mins small issues. Usually cosmetic fixes 3 we can defer this issue. But it'll good to implement it hard issue requires strong architecture skills, management skills, project domain area, etc cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it labels Mar 6, 2019
@duker33
Copy link
Collaborator

duker33 commented Mar 6, 2019

hard because it's arch task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 we can defer this issue. But it'll good to implement it 30 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable hard issue requires strong architecture skills, management skills, project domain area, etc take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd