Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search.py:53-54: Create a class instead this function.... #316

Open
0pdd opened this issue Mar 29, 2019 · 0 comments
Open

search.py:53-54: Create a class instead this function.... #316

0pdd opened this issue Mar 29, 2019 · 0 comments
Labels
3 we can defer this issue. But it'll good to implement it 30 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 29, 2019

The puzzle stb-537-a8b24119 from #stb-537 has to be resolved:

refarm-site/search/search.py

Lines 53 to 54 in e49a28b

@todo #stb-537:30m Create a class instead this function.
See there for details: https://github.com/fidals/refarm-site/pull/315/files#r270500698

The puzzle was created by Artemiy on 29-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Mar 29, 2019
@ArtemijRodionov
Stb#537 Fix field types determination for Search class (#315)
e49a28b 
* Fix field types determination for Search class

* Fix typo

* Remove dangling line

* Apply review fixes
@ArtemijRodionov ArtemijRodionov added 30 mins small issues. Usually cosmetic fixes 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it labels Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 we can defer this issue. But it'll good to implement it 30 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd