Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_views.py:89: Test crumbs siblings. #347

Open
0pdd opened this issue Sep 23, 2019 · 1 comment
Open

test_views.py:89: Test crumbs siblings. #347

0pdd opened this issue Sep 23, 2019 · 1 comment
Labels
3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 23, 2019

The puzzle 345-5d25d7b3 from #345 has to be resolved:

refarm-site/tests/catalog/test_views.py

Line 89 in 6350027

# @todo #345:30m Test crumbs siblings.

The puzzle was created by @duker33 on 23-Sep-19.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Sep 23, 2019
@duker33
#345 Implement crumbs (#346)
6350027 
* #345  Simplify breadcrumbs logic

* #345  Rm model.Page.get_index method

* #345  Implement breadcrumbs functions

* #345  Rm redundant "select_related" field

* #345  Minor logic fixes

* #345  Review#1 fix. Create two public methods instead of one with configuration
This was referenced Sep 23, 2019
Closed
Closed
@duker33 duker33 added 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable labels Sep 23, 2019
@duker33
Copy link
Collaborator

duker33 commented Sep 23, 2019

the are already tested at SE side, so it's not a hot task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd