Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context.py:113-117: Move context realization to pure to... #567

Closed
0pdd opened this issue Sep 7, 2018 · 6 comments
Closed

context.py:113-117: Move context realization to pure to... #567

0pdd opened this issue Sep 7, 2018 · 6 comments
Assignees
@ArtemijRodionov
Labels
1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable duplicate Tags STB's feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 7, 2018

The puzzle 550-c08f412e from #550 has to be resolved:

shopelectro/shopelectro/context.py

Lines 113 to 117 in 9399dd6

# @todo #550:120m Move context realization to pure to objects composition.
# Discussed some thoughts with Artemiy via call.
# Artemiy will do it.
# For example SortedCategory should
# consist of separated SortedList and Category classes/objects.

The puzzle was created by duker33 on 07-Sep-18.

Estimate: 120 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 7, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Sep 7, 2018
@duker33
#550 Split TaggedCategoryPage class (#551)
9399dd6 
* #550  Review#3 fixes. Rm get_tags caching

#550  Resolve branch inner conflicts

#550  Apply linter rules

#550  Review#2 fixes. Rm redundant pdd issue, fix imports

#550  Rm redundant pdd issue

#550  Pdd issue about context module improving

#550  Merge fixes after hell

#550  Minor self-review fixes

#550  Add code example for creating context

#550  Make context names shorten

#550  Fork AbstractPageContext

#550  Cleanup code

#550  Fork PaginationCategoryContext class

#550  Fork SortingCategoryContext class

#550  Fork DBTemplateContext class. Improve pipe mech

#550  Fork TaggedCategoryContext class

#550  Implement CatalogContext

#550  Fork SortingCategoryPage class

#550  Fork PaginatedCatalogPage class

#550  Fork DBContextCatalogPage class

#548  Apply E305 linter rule

#550  Review#1 fixes. Cache in memory db queries

#548  Rm E305 pycodestyle rule

#550  Add pdd issue for continue splitting

#550  Create TaggedCategoryPage class

* #550  Merge fixes

* #550  Fix shadowed var

* #550  Apply linter rules after rebase
@0pdd 0pdd mentioned this issue Sep 7, 2018
Closed
@duker33
Copy link
Contributor

duker33 commented Sep 7, 2018

connected with #566

@duker33 duker33 added 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable Tags STB's feature labels Sep 7, 2018
@duker33 duker33 added 1 burning issue and removed 2 performer can implement issue at his closest convenient time labels Sep 17, 2018
@duker33
Copy link
Contributor

duker33 commented Sep 17, 2018

this task blocks huge set of views cleanup tasks. So, 1 tag

@duker33 duker33 mentioned this issue Sep 17, 2018
Merged
@0pdd 0pdd closed this as completed Sep 17, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 17, 2018

The puzzle 550-c08f412e has disappeared from the source code, that's why I closed this issue. //cc @artemiyds2 @duker33

0pdd referenced this issue Sep 17, 2018
@duker33
#577 Move context module to refarm.catalog app (#580)
e15ec5b 
* #577  Move context module to refarm.catalog app

* #577  Grade refarm dep to 0.4.1
@duker33
Copy link
Contributor

duker33 commented Sep 17, 2018

it's not closed truly. It's pdd code just moved to refarm repo

@duker33 duker33 reopened this Sep 17, 2018
@duker33
Copy link
Contributor

duker33 commented Sep 20, 2018

actual task is here:
fidals/refarm-site#183

@duker33 duker33 closed this as completed Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research cleanup everything that do project stronger, flexible, reusable duplicate Tags STB's feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd