Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context.py:261-262: Move TaggedCategory.get_tags to... #579

Closed
0pdd opened this issue Sep 16, 2018 · 4 comments
Closed

context.py:261-262: Move TaggedCategory.get_tags to... #579

0pdd opened this issue Sep 16, 2018 · 4 comments
Assignees
@duker33
Labels
3 we can defer this issue. But it'll good to implement it 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable duplicate Tags STB's feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 16, 2018

The puzzle 550-79bb63d1 from #550 has to be resolved:

shopelectro/shopelectro/context.py

Lines 261 to 262 in b175023

# @todo #550:15m Move `TaggedCategory.get_tags` to property.
# As in `products` property case.

The puzzle was created by duker33 on 16-Sep-18.

Estimate: 15 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 16, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Sep 16, 2018
@duker33
rf#168 Prepare context module for moving to refarm (#573)
b175023 
* rf#168  Inject products queryset to catalog context

* rf#168  Fix se#550's rebase. Inject tag qs tag context

* rf#168  Move tag_pairs stuff from catalog context to tags one

* rf#168  Broken code. Move to QS receive

* rf#168  Fix distinct-order_by bug

* rf#168  Implement new interface for `context.prepare_products`

* #550  Add minor pdd issue

* #550  Pdd issue to move context to refarm.catalog app

* rf#168  Grade refarm dep, minor fix in test_views

* rf#168  Apply linter rules
@0pdd 0pdd mentioned this issue Sep 16, 2018
Closed
@duker33 duker33 added 15 mins small issues. Usually cosmetic fixes 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable Tags STB's feature labels Sep 17, 2018
@duker33 duker33 self-assigned this Sep 17, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 17, 2018

The puzzle 550-79bb63d1 has disappeared from the source code, that's why I closed this issue. //cc @artemiyds2 @duker33

@0pdd 0pdd closed this as completed Sep 17, 2018
0pdd referenced this issue Sep 17, 2018
@duker33
#577 Move context module to refarm.catalog app (#580)
e15ec5b 
* #577  Move context module to refarm.catalog app

* #577  Grade refarm dep to 0.4.1
@duker33
Copy link
Contributor

duker33 commented Sep 17, 2018

it's not closed truly. It's pdd code just moved to refarm repo

@duker33 duker33 reopened this Sep 17, 2018
@duker33
Copy link
Contributor

duker33 commented Sep 22, 2018

duplicates fidals/refarm-site#185

@duker33 duker33 closed this as completed Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
3 we can defer this issue. But it'll good to implement it 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable duplicate Tags STB's feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd