Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context.py:7: Remove the ProductImages in favor of... #698

Closed
0pdd opened this issue Jan 18, 2019 · 1 comment
Closed

context.py:7: Remove the ProductImages in favor of... #698

0pdd opened this issue Jan 18, 2019 · 1 comment
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jan 18, 2019

The puzzle 683-0642f414 from #683 has to be resolved:

shopelectro/shopelectro/context.py

Line 7 in 7f3bf67

# @todo #683:60m Remove the ProductImages in favor of catalog.newcontext.ProductImages

The puzzle was created by Artemiy on 18-Jan-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 18, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jan 18, 2019
@ArtemijRodionov
#683 new context (#689)
7f3bf67 
* Create get_catalog_context and use it

* Adopte templates to new Pagination mech

* Add temp dependency on refarm-site's branch

* Inject  to category page

* Self-review fixes

* Apply linter rules

* Fix volume paths to refarm-site packages in docker-compose.yml

* Create todo and bump refarm version

* Review fixes

* Fix pdd task format. Apply linter rules

* Clarify todo for category context class(es).
@0pdd 0pdd mentioned this issue Jan 18, 2019
Closed
@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour 1 burning issue cleanup everything that do project stronger, flexible, reusable labels Jan 18, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Jan 18, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Jan 19, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Jan 20, 2019
@ArtemijRodionov
#698 remove se.ProductImages (#703)
0437448 
* Remove se_context.ProductImages in favor of newcontext.ProductImages

* Remove se_context.ProductImages

* Fix imports for newcontext classes
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd