Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catalog.py:47-48: Remove *Tags and *Products suffixes... #700

Closed
0pdd opened this issue Jan 18, 2019 · 2 comments
Closed

catalog.py:47-48: Remove *Tags and *Products suffixes... #700

0pdd opened this issue Jan 18, 2019 · 2 comments
Labels
2 performer can implement issue at his closest convenient time 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jan 18, 2019

The puzzle 683-2a584c01 from #683 has to be resolved:

shopelectro/shopelectro/views/catalog.py

Lines 47 to 48 in 7f3bf67

# @todo #683:30m Remove *Tags and *Products suffixes from catalog.newcontext classes.
# Rename Checked404Tags to ExistingOr404.

The puzzle was created by Artemiy on 18-Jan-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 18, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jan 18, 2019
@ArtemijRodionov
#683 new context (#689)
7f3bf67 
* Create get_catalog_context and use it

* Adopte templates to new Pagination mech

* Add temp dependency on refarm-site's branch

* Inject  to category page

* Self-review fixes

* Apply linter rules

* Fix volume paths to refarm-site packages in docker-compose.yml

* Create todo and bump refarm version

* Review fixes

* Fix pdd task format. Apply linter rules

* Clarify todo for category context class(es).
@0pdd 0pdd mentioned this issue Jan 18, 2019
Closed
@ArtemijRodionov ArtemijRodionov added 30 mins middle-sized issue. Usually a part of feature or a fix take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable 2 performer can implement issue at his closest convenient time labels Jan 18, 2019
@0pdd 0pdd closed this as completed Mar 16, 2019
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 16, 2019

The puzzle 683-2a584c01 has disappeared from the source code, that's why I closed this issue. //cc @artemiyds2 @duker33

0pdd referenced this issue Mar 16, 2019
@duker33
#set of minor fixes related to stb (#773)
a6d798a 
* stb#447  Move Request class to the refarm side

* stb#450  Create ContextDict type at refarm side

* stb#444  Move catalog Page to refarm side

* #fix  Uncomment docker-compose mounted refarm code

* rf#260  Rename "newcontext" to "context"

* #set  Grade refarm version to 0.5.1

* rf#309  Adapt context to the new structure

* #set  Grade refarm to 0.5.2

* #fix  catalog.context structure issue

* #set  Grade refarm to 0.5.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 performer can implement issue at his closest convenient time 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd